openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 06:23:18 +02:00
Code Issues Releases Wiki Activity

tests: assert pathname and flags when calling open()

Browse Source 
With this change the wrappers for mock and friends are able to take an
optional io_mock_fallback_open_state struct to assert expected pathnames
and flags whenever an open operation is called.

Based partially on https://review.coreboot.org/c/flashrom/+/62319/5

BUG=b:227404721,b:217629892,b:215255210
TEST=./test_build.sh; FEATURES=test emerge-amd64-generic flashrom
BRANCH=none

Signed-off-by: Daniel Campello <campello@chromium.org>
Co-Author: Edward O'Callaghan <quasisec@google.com>
Change-Id: Ib46ca5b854c8453ec02ae09f3151cd4d25f988eb
Reviewed-on: https://review.coreboot.org/c/flashrom/+/63227
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
This commit is contained in:
Daniel Campello
2022-03-29 20:47:46 -06:00
committed by Anastasia Klimchuk
parent 9454336970
commit 885fb2e82b
4 changed files with 48 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/lifecycle.c
View File

@ -370,13 +370,6 @@ void linux_spi_probe_lifecycle_test_success(void **state)
#endif
}
static int realtek_mst_open(void *state, const char *pathname, int flags)
{
assert_string_equal(pathname, "/dev/i2c-254");
assert_int_equal(flags & O_RDWR, O_RDWR);
return MOCK_FD;
}
static int realtek_mst_ioctl(void *state, int fd, unsigned long request, va_list args)
{
assert_int_equal(fd, MOCK_FD);
@ -406,11 +399,16 @@ static int realtek_mst_write(void *state, int fd, const void *buf, size_t sz)
void realtek_mst_basic_lifecycle_test_success(void **state)
{
#if CONFIG_REALTEK_MST_I2C_SPI == 1
static struct io_mock_fallback_open_state realtek_mst_fallback_open_state = {
.noc = 0,
.paths = { "/dev/i2c-254", NULL },
.flags = { O_RDWR },
};
const struct io_mock realtek_mst_io = {
.open = realtek_mst_open,
.ioctl = realtek_mst_ioctl,
.read = realtek_mst_read,
.write = realtek_mst_write,
.fallback_open_state = &realtek_mst_fallback_open_state,
};
io_mock_register(&realtek_mst_io);