openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 07:02:34 +02:00
Code Issues Releases Wiki Activity

raiden_debug_spi.c: Document where raiden_debug_spi_requests are handled

Browse Source 
Because the enum is a different name to the one within cr50 it
was entirely unclear where these values were handled at the end-point
and what a untargetted REQ_ENABLE actually did. Comment to avoid
needing to chase this again.

BUG=b:224358254
TEST=builds

Change-Id: I8cc78a85660190c9f750bf67994f0d59d69592d8
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/63902
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
This commit is contained in:
Edward O'Callaghan 2022-04-28 13:31:52 +10:00 committed by Edward O'Callaghan
parent cb7e627f11
commit 9f44e1494d
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
raiden_debug_spi.c
View File

@ -399,6 +399,10 @@ enum usb_spi_error {
USB_SPI_UNKNOWN_ERROR = 0x8000,
};
/* Corresponds with 'enum usb_spi_request' in,
* platform/cr50/chip/g/usb_spi.h and,
* platform/ec/chip/stm32/usb_spi.h.
*/
enum raiden_debug_spi_request {
RAIDEN_DEBUG_SPI_REQ_ENABLE = 0x0000,
RAIDEN_DEBUG_SPI_REQ_DISABLE = 0x0001,
@ -1445,6 +1449,10 @@ static int get_ap_request_type(void)
static int get_target(void)
{
/**
* REQ_ENABLE doesn't specify a target bus, and will be rejected
* by adapters that support more than one target.
*/
int request_enable = RAIDEN_DEBUG_SPI_REQ_ENABLE;
char *target_str = extract_programmer_param("target");