openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 14:11:15 +02:00
Code Issues Releases Wiki Activity

linux_mtd: Free param right after its last usage

Browse Source 
Param is only used in the first half of init function, and it is
local, so there is no need to keep it until the end. This makes
handling error paths in the second half of init function shorter,
because those paths can just return 1 instead of going to a label.

BUG=b:185191942
TEST=builds and ninja test from CB:56413

Change-Id: I126a8d06297ef4d42bc93a73f7067ccc1352d1e9
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56822
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Anastasia Klimchuk
2021-08-03 15:26:19 +10:00
committed by Nico Huber
parent e44e6eb32f
commit c87a770f5d
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
linux_mtd.c
View File

@ -404,27 +404,29 @@ static int linux_mtd_init(void)
msg_pdbg("%s does not exist\n", sysfs_path);
goto linux_mtd_init_exit;
}
free(param);
data = calloc(1, sizeof(*data));
if (!data) {
msg_perr("Unable to allocate memory for linux_mtd_data\n");
goto linux_mtd_init_exit;
return 1;
}
/* Get MTD info and store it in `data` */
if (linux_mtd_setup(dev_num, data)) {
free(data);
goto linux_mtd_init_exit;
return 1;
}
if (register_shutdown(linux_mtd_shutdown, (void *)data)) {
free(data);
goto linux_mtd_init_exit;
return 1;
}
register_opaque_master(&linux_mtd_opaque_master, data);
ret = 0;
return 0;
linux_mtd_init_exit:
free(param);
return ret;