openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

flashrom.c: Position heap alloc along side check in compare_range()

Browse Source 
Change-Id: I0386ac4c09a541cb9a659b2410ce49c3292ecc6e
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/69473
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Alexander Goncharov <chat@joursoir.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Edward O'Callaghan 2022-11-12 12:08:01 +11:00 committed by Edward O'Callaghan
parent 1e01eefcba
commit d1212796ab
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
flashrom.c
View File

@ -471,15 +471,16 @@ static int compare_range(const uint8_t *wantbuf, const uint8_t *havebuf, unsigne
static int check_erased_range(struct flashctx *flash, unsigned int start, unsigned int len) static int check_erased_range(struct flashctx *flash, unsigned int start, unsigned int len)
{ {
int ret; int ret;
uint8_t *cmpbuf = malloc(len);
const uint8_t erased_value = ERASED_VALUE(flash); const uint8_t erased_value = ERASED_VALUE(flash);
uint8_t *cmpbuf = malloc(len);
if (!cmpbuf) { if (!cmpbuf) {
msg_gerr("Out of memory!\n"); msg_gerr("Out of memory!\n");
return -1; return -1;
} }
memset(cmpbuf, erased_value, len); memset(cmpbuf, erased_value, len);
ret = verify_range(flash, cmpbuf, start, len); ret = verify_range(flash, cmpbuf, start, len);
free(cmpbuf); free(cmpbuf);
return ret; return ret;
} }