openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-29 16:03:47 +02:00
Code Issues Releases Wiki Activity

Add -W options from Makefile into meson warning_flags

Browse Source 
Makefile options were more restrictive and produced more
warnings. This patch adds missing warning options into
meson build.

Makefile also has -Wall and -Wextra specified explicitly,
however this is covered by warning_level=2 which is already
set in meson.build. warning_level info:
https://github.com/mesonbuild/meson/issues/3275

There are few warning options that are present in meson,
but not in Makefile. These are left as is.

TEST=ninja test shows no warnings and tests pass

Change-Id: Id401bfd642dc3c13d85bd9a2dba56ada38714c25
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/58561
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
This commit is contained in:
Anastasia Klimchuk 2021-10-25 13:20:26 +11:00
parent c4784f1a9a
commit d431358621
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
meson.build
View File

@ -13,6 +13,8 @@ lt_version = '@0@.@1@.@2@'.format(lt_current, lt_age, lt_revision)
# hide/enable some warnings # hide/enable some warnings
warning_flags = [ warning_flags = [
'-Wshadow',
'-Wmissing-prototypes',
'-Wwrite-strings', '-Wwrite-strings',
'-Wno-unused-parameter', '-Wno-unused-parameter',
'-Wno-address-of-packed-member', '-Wno-address-of-packed-member',