1
0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 15:12:36 +02:00

flashrom_tester: Log some cros lsb-release information

os-release does not quite have as much information so use lsb-release.

BUG=b:258289727
BRANCH=None
TEST=flashrom_tester --libflashrom host Lock

Change-Id: If3452ead9e02e0ddeaa0fdf4852d7c17a8ab7650
Signed-off-by: Evan Benn <evanbenn@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/69403
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Evan Benn 2022-11-09 16:57:53 +11:00 committed by Edward O'Callaghan
parent 63ae7ae91c
commit d8be2ced58
3 changed files with 15 additions and 0 deletions

View File

@ -34,6 +34,7 @@
//
use std::ffi::OsStr;
use std::fs;
use std::io::Result as IoResult;
use std::process::{Command, Stdio};
@ -58,3 +59,12 @@ pub fn system_info() -> IoResult<String> {
pub fn bios_info() -> IoResult<String> {
dmidecode_dispatch(&["-q", "-t0"])
}
pub fn release_description() -> IoResult<String> {
for l in fs::read_to_string("/etc/lsb-release")?.lines() {
if l.starts_with("CHROMEOS_RELEASE_DESCRIPTION") {
return Ok(l.to_string());
}
}
Err(std::io::ErrorKind::NotFound.into())
}

View File

@ -348,6 +348,7 @@ pub enum TestConclusion {
pub struct ReportMetaData {
pub chip_name: String,
pub os_release: String,
pub cros_release: String,
pub system_info: String,
pub bios_info: String,
}
@ -451,6 +452,7 @@ pub fn collate_all_test_runs(
println!();
println!(" %---------------------------%");
println!(" os release: {}", meta_data.os_release);
println!(" cros release: {}", meta_data.cros_release);
println!(" chip name: {}", meta_data.chip_name);
println!(" system info: \n{}", meta_data.system_info);
println!(" bios info: \n{}", meta_data.bios_info);

View File

@ -134,12 +134,15 @@ pub fn generic<'a, TN: Iterator<Item = &'a str>>(
}
let os_release = sys_info::os_release().unwrap_or("<Unknown OS>".to_string());
let cros_release = cros_sysinfo::release_description()
.unwrap_or("<Unknown or not a ChromeOS release>".to_string());
let system_info = cros_sysinfo::system_info().unwrap_or("<Unknown System>".to_string());
let bios_info = cros_sysinfo::bios_info().unwrap_or("<Unknown BIOS>".to_string());
let meta_data = tester::ReportMetaData {
chip_name,
os_release,
cros_release,
system_info,
bios_info,
};