openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 22:21:16 +02:00
Code Issues Releases Wiki Activity

Use the register mapping feature bit

Browse Source 
All functions which just call probe_jedec and then map flash registers
are replaced by probe_jedec. All functions which call probe_jedec, map
flash registers and do something else can at least eliminate mapping
flash registers.
Fix logic inversion in probe_jedec to map flash registers on success
instead of on failure.
Change a few TIMING_IGNORED to TIMING_FIXME where probe_jedec is used.

Total savings: One probe function simplified, three probe functions
eliminated.

Corresponding to flashrom svn r839.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
Acked-by: Sean Nelson <audiohacked@gmail.com>
This commit is contained in:
Carl-Daniel Hailfinger
2010-01-09 02:24:17 +00:00
parent 3646c8f31f
commit e9404668a1
6 changed files with 29 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
jedec.c
View File

@ -189,13 +189,13 @@ int probe_jedec_common(struct flashchip *flash,
printf_debug(", id2 is normal flash content");
printf_debug("\n");
if (largeid1 == flash->manufacture_id && largeid2 == flash->model_id)
return 1;
if (largeid1 != flash->manufacture_id || largeid2 != flash->model_id)
return 0;
if (flash->feature_bits & FEATURE_REGISTERMAP)
map_flash_registers(flash);
return 0;
return 1;
}
int erase_sector_jedec_common(struct flashchip *flash, unsigned int page,