openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-26 22:52:34 +02:00
Code Issues Releases Wiki Activity

git-hooks: echo back the commit message on failure

Browse Source 
When using nano as a git commit message editor the contents of the
commit message could get lost if the git commit hook fails due to
the lack of Signed-off-by line. To prevent this unpleasant effect
for new contributors the commit hook was modified to echo back the
commit message to allow the user to copy-paste it to the message
of the next commit attempt.

Change-Id: I13289f81b3fa92640aecc43eae28c1643cd7c247
Signed-off-by: Miklós Márton <martonmiklosqdev@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/62879
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Miklós Márton 2022-03-16 23:21:04 +01:00 committed by Anastasia Klimchuk
parent 4fbb152402
commit ffc75aa710
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/git-hooks/commit-msg
View File

@ -196,6 +196,7 @@ _gen_ChangeId() {
test_signoff() {
if ! grep -qi '^[[:space:]]*\+Signed-off-by:' "$MSG"; then
cat "$MSG"
printf "\nError: No Signed-off-by line in the commit message.\n"
printf "See: ${DEV_GUIDELINES_URL}\n"
exit 1
@ -206,6 +207,7 @@ test_signoff() {
test_duplicate_signoffs_acks() {
test "" = "$(grep -i '^(Signed-off-by|Acked-by): ' "$MSG" |
sort | uniq -c | sed -e '/^[[:space:]]*1[[:space:]]/d')" || {
cat "$MSG"
echo "Duplicate Signed-off-by or Acked-by lines." >&2
exit 1
}