mirror of
https://review.coreboot.org/flashrom.git
synced 2025-10-17 15:51:53 +02:00
3461f65b23
If the flash chip is larger than 16MiB, the memory mapped read from top of 4G address will not work properly, resulting in accesses to addresses below 0xff000000. In such cases flashrom fails with "Bus error". Fallback to default_spi_read for flashes larger than 16 MiB. Using memory mapped access with ROM3 register could be implemented, however it introduces the complexity of ROM page remapping. I.e. the PSP may remap 16MiB pages of 32MiB or larger flashes by XORing the host memory mapped address bits [31:24]. It results in non-linear memory mapped flash space. Fixes the issue: https://ticket.coreboot.org/issues/370 TEST=Read complete flash content on Gigabyte MZ33-AR1 running coreboot. Change-Id: I218a4c2dbf7cd7e8fa25b3ecb5aeac03f54f9dc6 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/89446 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Peter Marheine <pmarheine@chromium.org> Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
40 lines
1.3 KiB
ReStructuredText
40 lines
1.3 KiB
ReStructuredText
===============================
|
|
Recent development (unreleased)
|
|
===============================
|
|
|
|
This document describes the major changes that are expected to be included in
|
|
the next release of flashrom and which are currently only available by source
|
|
code checkout (see :doc:`../dev_guide/building_from_source`). These changes
|
|
may be further revised before the next release.
|
|
|
|
Bugs fixed
|
|
==========
|
|
|
|
AMD-based PCs with FCH were unable to read flash contents for internal (BIOS
|
|
flash) chips larger than 16 MB, and attempting to do so could crash the
|
|
system.
|
|
|
|
https://ticket.coreboot.org/issues/370
|
|
|
|
Added support
|
|
=============
|
|
|
|
* Intel Wildcat Lake chipset
|
|
* Eon EN25QX128A
|
|
* PUYA P25D80H
|
|
|
|
New features
|
|
============
|
|
|
|
Fail immediately when trying to write/erase wp regions
|
|
------------------------------------------------------
|
|
|
|
This change is done so it's harder for user to brick his own platform.
|
|
Information about read-only regions can easily be missed as flashrom
|
|
can output a lot of information on screen. Even if you notice you might
|
|
not know if one of the regions you requested falls inside read-only
|
|
range, especially if using different names for those regions.
|
|
If you are flashing multiple regions or ones that partially overlap with
|
|
read-only parts then that could result in flashrom failing in the
|
|
middle, leaving you in unknown state.
|