1
0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-28 07:23:43 +02:00
Evan Benn eab04615ee flashrom_tester: Remove --output log redirect option
Always print logs to stdout. User can redirect logs in the normal way if
they wish.

BUG=b:194245688
BRANCH=None
TEST=clippy, unit

Change-Id: I5eab8169644a16ba31b203e8607853c459f92978
Signed-off-by: Evan Benn <evanbenn@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/71773
Reviewed-by: Nikolai Artemiev <nartemiev@google.com>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
2023-01-31 01:56:31 +00:00

150 lines
4.7 KiB
Rust

//
// Copyright 2019, Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
//
// Alternatively, this software may be distributed under the terms of the
// GNU General Public License ("GPL") version 2 as published by the Free
// Software Foundation.
//
use flashrom_tester::types;
use std::io::Write;
struct Logger {
level: log::LevelFilter,
color: types::Color,
}
impl log::Log for Logger {
fn enabled(&self, metadata: &log::Metadata) -> bool {
metadata.level() <= self.level
}
fn log(&self, record: &log::Record) {
// Write errors deliberately ignored
let stdout = std::io::stdout();
let mut lock = stdout.lock();
let now = chrono::Utc::now().to_rfc3339_opts(chrono::SecondsFormat::Micros, true);
let _ = write!(lock, "{}{} ", self.color.magenta, now);
let _ = write!(
lock,
"{}[ {} ]{} ",
self.color.yellow,
record.level(),
self.color.reset
);
let _ = writeln!(lock, "{}", record.args());
}
fn flush(&self) {
// Flush errors deliberately ignored
let _ = std::io::stdout().flush();
}
}
pub fn init(debug: bool) {
let mut logger = Logger {
level: log::LevelFilter::Info,
color: if atty::is(atty::Stream::Stdout) {
types::COLOR
} else {
types::NOCOLOR
},
};
if debug {
logger.level = log::LevelFilter::Debug;
}
log::set_max_level(logger.level);
log::set_boxed_logger(Box::new(logger)).unwrap();
}
#[cfg(test)]
mod tests {
use std::io::Read;
use super::Logger;
use flashrom_tester::types;
use log::{Level, LevelFilter, Log, Record};
fn run_records(records: &[Record]) -> String {
let buf = gag::BufferRedirect::stdout().unwrap();
{
let logger = Logger {
level: LevelFilter::Info,
color: types::COLOR,
};
for record in records {
if logger.enabled(record.metadata()) {
logger.log(record);
}
}
}
let mut ret = String::new();
buf.into_inner().read_to_string(&mut ret).unwrap();
ret
}
/// Log messages have the expected format
#[test]
fn format() {
let buf = run_records(&[Record::builder()
.args(format_args!("Test message at INFO"))
.level(Level::Info)
.build()]);
assert_eq!(&buf[..5], "\x1b[35m");
// Time is difficult to test, assume it's formatted okay
// Split on the UTC timezone char
assert_eq!(
buf.split_once("Z ").unwrap().1,
"\x1b[33m[ INFO ]\x1b[0m Test message at INFO\n"
);
}
#[test]
fn level_filter() {
let buf = run_records(&[
Record::builder()
.args(format_args!("Test message at DEBUG"))
.level(Level::Debug)
.build(),
Record::builder()
.args(format_args!("Hello, world!"))
.level(Level::Error)
.build(),
]);
// There is one line because the Debug record wasn't written.
println!("{}", buf);
assert_eq!(buf.lines().count(), 1);
}
}