openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-26 22:52:34 +02:00
Code Issues Releases Wiki Activity

erasure_layout: Fix unaligned region end offset by 1

Browse Source 
In the case when layout region is not aligned with eraseblock,
end region boundary is extended to match the eraseblock. There is
a special handling of this extended area (between original end of
region and extended one). Fix the offset of this extended area by +1
so that it covers the extended area and not the original region.

Before the patch, the last byte of the original region was failed to
write since it was treated as if an extended area, while it was the
last byte of the normal layout region.

Ticket: https://ticket.coreboot.org/issues/494
Change-Id: I7f78a0090065cd2a952cba1a5d28179483ba4c55
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/78984
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
This commit is contained in:
Anastasia Klimchuk 2023-11-09 23:29:41 +11:00 committed by Anastasia Klimchuk
parent bb8e6f904b
commit 48b9ece5ad
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
erasure_layout.c
View File

@ -279,9 +279,10 @@ int erase_write(struct flashctx *const flashctx, chipoff_t region_start, chipoff
memcpy(newcontents + region_start, curcontents + region_start, old_start - region_start);
}
if (region_end - old_end) {
read_flash(flashctx, curcontents + old_end, old_end, region_end - old_end);
memcpy(old_end_buf, newcontents + old_end, region_end - old_end);
memcpy(newcontents + old_end, curcontents + old_end, region_end - old_end);
chipoff_t end_offset = old_end + 1;
read_flash(flashctx, curcontents + end_offset, end_offset, region_end - old_end);
memcpy(old_end_buf, newcontents + end_offset, region_end - old_end);
memcpy(newcontents + end_offset, curcontents + end_offset, region_end - old_end);
}
// select erase functions