mirror of
https://review.coreboot.org/flashrom.git
synced 2025-04-28 15:33:42 +02:00
vt_vx: check whether the chipset's MMIO range is configured
Avoid attempting to read the SPI bases from the location 0x00000000, all zeroes mean that the chipset's MMIO area is not enabled. Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> Reviewed-on: https://review.coreboot.org/23029 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: David Hendricks <david.hendricks@gmail.com>
This commit is contained in:
parent
aac81424eb
commit
d0803c8407
@ -1013,10 +1013,18 @@ static int enable_flash_vt_vx(struct pci_dev *dev, const char *name)
|
||||
switch(dev->device_id) {
|
||||
case 0x8353: /* VX800/VX820 */
|
||||
spi0_mm_base = pci_read_long(dev, 0xbc) << 8;
|
||||
if (spi0_mm_base == 0x0) {
|
||||
msg_pdbg ("MMIO not enabled!\n");
|
||||
return ERROR_FATAL;
|
||||
}
|
||||
break;
|
||||
case 0x8409: /* VX855/VX875 */
|
||||
case 0x8410: /* VX900 */
|
||||
mmio_base = pci_read_long(dev, 0xbc) << 8;
|
||||
if (mmio_base == 0x0) {
|
||||
msg_pdbg ("MMIO not enabled!\n");
|
||||
return ERROR_FATAL;
|
||||
}
|
||||
mmio_base_physmapped = physmap("VIA VX MMIO register", mmio_base, SPI_CNTL_LEN);
|
||||
if (mmio_base_physmapped == ERROR_PTR)
|
||||
return ERROR_FATAL;
|
||||
|
Loading…
x
Reference in New Issue
Block a user