openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

ft2232_spi: Don't lower write data chunksize

Browse Source 
This "chunk size" limits the amount of data that is passed to libusb
at once. If we had exceeded the chunk size, libftdi would have split
the data into individual, synchronous bulk transfers. But the chunk
size was actually chosen to avoid this. So without any known effect,
setting the chunk size is useless. Drop it.

Change-Id: I779e24dc3f3379a98ddce02c3765062ac3241884
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55683
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
This commit is contained in:
Nico Huber 2021-06-20 13:09:30 +02:00
parent 4d5a3b5eb0
commit f949a3d1c6
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ft2232_spi.c
View File

@ -651,10 +651,6 @@ static int ft2232_spi_init(void)
msg_perr("Unable to set latency timer (%s).\n", ftdi_get_error_string(&ftdic)); msg_perr("Unable to set latency timer (%s).\n", ftdi_get_error_string(&ftdic));
} }
if (ftdi_write_data_set_chunksize(&ftdic, 270)) {
msg_perr("Unable to set chunk size (%s).\n", ftdi_get_error_string(&ftdic));
}
if (ftdi_set_bitmode(&ftdic, 0x00, BITMODE_BITBANG_SPI) < 0) { if (ftdi_set_bitmode(&ftdic, 0x00, BITMODE_BITBANG_SPI) < 0) {
msg_perr("Unable to set bitmode to SPI (%s).\n", ftdi_get_error_string(&ftdic)); msg_perr("Unable to set bitmode to SPI (%s).\n", ftdi_get_error_string(&ftdic));
} }