mirror of
https://review.coreboot.org/flashrom.git
synced 2025-09-13 16:51:58 +02:00
fa2d2ccb945b4c70ea324c14459dae5a31287bc4

The last argument in `prepare_flash_access` function indicates whether verify operation was requested. This information is in the flag `verify_after_write` in flash context, so lets pass it to the function. Previously, the last argument which is called `verify_it` was always `false`. This hasn't been detected because in the current implementation of `prepare_flash_access`, `verify_it` is always checked together with `erase_it`, the latter was passed always true. `verify_it` being false is wrong because we have a flag to decide about verification. Also this false value contradicts reality, because erase operation ignores the flag and always verifies (this has always been the case even with earlier implementations of erase logic). Additional context is in the next commit and ticket https://ticket.coreboot.org/issues/520 Change-Id: Idd7526084e4942b7adbbab57a62f7de84b4a4bb5 Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/88733 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
flashrom README =============== flashrom is a utility for detecting, reading, writing, verifying and erasing flash chips. It is often used to flash BIOS/EFI/coreboot/firmware images in-system using a supported mainboard, but it also supports flashing of network cards (NICs), SATA controller cards, and other external devices which can program flash chips. It supports a wide range of flash chips (most commonly found in SOIC8, DIP8, SOIC16, WSON8, PLCC32, DIP32, TSOP32, and TSOP40 packages), which use various protocols such as LPC, FWH, parallel flash, or SPI. Do not use flashrom on laptops (yet)! The embedded controller (EC) present in many laptops might interact badly with any attempts to communicate with the flash chip and may brick your laptop. Please make a backup of your flash chip before writing to it. Please see the flashrom(8) manpage :doc:`classic_cli_manpage`. The list of platforms that package flashrom can be found on `repology.org <https://repology.org/project/flashrom/versions>`_. Information about recent releases can be found in :doc:`/release_notes/index`. Building / installing / packaging --------------------------------- flashrom is built with **meson**. TLDR: :: meson setup builddir meson compile -C builddir meson test -C builddir meson install -C builddir For full detailed instructions, follow the information in :doc:`dev_guide/building_from_source`. If you are interested in development, have a look at :doc:`dev_guide/development_guide`. Contact ------- The official flashrom website is: https://www.flashrom.org/ For available contact methods see :doc:`contact`
Description
Languages
C
90.2%
Rust
5%
Shell
2%
Makefile
1.6%
Meson
1.2%